Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(e2e): account for a recurring MFA reminder when singing in to cloud ui #6429

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

gribnoysup
Copy link
Collaborator

@gribnoysup gribnoysup commented Nov 1, 2024

Haven't thought that this screen shows up over time after being dismissed, so the CI is currently failing because the sign in flow can't be finished. This patch adds a check for the dismiss button running in parallel to waiting for the auth request to resolve, so we either resolve when auth is done or this screen appears and we click the button and then wait for the auth

Unless you're trying this locally with your account it's kinda hard to repro for testing purposes, but I ran this tests twice locally against the account like that to make sure that 1) it's dismissed when appears 2) the code is not blocking the sign in when it doesn't appear, and both scenarios worked

@gribnoysup gribnoysup added no release notes Fix or feature not for release notes no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion) labels Nov 1, 2024
@github-actions github-actions bot added the fix label Nov 1, 2024
@gribnoysup
Copy link
Collaborator Author

Merging to unblock CI

@gribnoysup gribnoysup merged commit 649c208 into main Nov 1, 2024
36 checks passed
@gribnoysup gribnoysup deleted the fix-e2e-compass-web-mfa-check branch November 1, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix no release notes Fix or feature not for release notes no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant